Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.21.4 #211

Merged
merged 30 commits into from
Jan 10, 2025
Merged

Update to 1.21.4 #211

merged 30 commits into from
Jan 10, 2025

Conversation

ChampionAsh5357
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 commented Dec 3, 2024 •
edited
Loading

Applies the contribution formatting and updates the docs to 1.21.4.

Waiting For

neoforged/NeoForge#1777
neoforged/NeoForge#1725

Closes

Closes #213
Closes #212
Supercedes #214

Subsections

  • Advanced
  • Block Entities
  • Blocks
  • Concepts
  • Data Storage
  • Getting Started
  • GUI
  • Items
  • Legacy
  • Misc
  • Networking
  • Resources
    • Client
      • Items (new)
      • Models
        • Datagen (Wait on 1725)
    • Server
      • Data Maps
      • Enchantments
      • Loot Tables
      • Recipes
  • World Generation

Preview URL: https://pr-211.neoforged-docs-previews.pages.dev

@ChampionAsh5357 ChampionAsh5357 added update Previously correct, but now outdated information. large Major additions or changes. labels Dec 3, 2024
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 3, 2024 21:25 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Dec 3, 2024 •
edited
Loading

Deploying with Cloudflare Pages

Name Result
Last commit: a68876e1ed34945968cf925da34ad1052227be94
Status: ✅ Deploy successful!
Preview URL: https://ac4cdc69.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-211.neoforged-docs-previews.pages.dev

@IchHabeHunger54 IchHabeHunger54 self-requested a review December 8, 2024 13:59
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 16:22 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 16:50 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 17:26 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 17:38 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 18:36 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 18:52 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 18:58 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2024 01:13 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2024 01:21 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2024 01:34 Active
@ChampionAsh5357 ChampionAsh5357 requested review from IchHabeHunger54 and a team December 27, 2024 23:34
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 27, 2024 23:37 Active
XFactHD
XFactHD requested changes Dec 29, 2024
View reviewed changes
Copy link
Member

@XFactHD XFactHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to look over the model datagen and item model pages.

docs/resources/client/models/bakedmodel.md Outdated Show resolved Hide resolved
docs/resources/client/models/bakedmodel.md Outdated Show resolved Hide resolved
docs/resources/client/models/index.md Outdated Show resolved Hide resolved
docs/resources/client/models/index.md Outdated Show resolved Hide resolved
docs/resources/index.md Outdated Show resolved Hide resolved
docs/resources/client/models/modelloaders.md Outdated Show resolved Hide resolved
docs/resources/client/models/modelloaders.md Outdated Show resolved Hide resolved
@ChampionAsh5357 @XFactHD
fix(docs): Apply Xfact's suggestions
92d4362 
Co-authored-by: Dennis C <xfacthd@gmx.de>
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 29, 2024 17:19 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 29, 2024 17:30 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 29, 2024 17:38 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 29, 2024 17:42 Active
IchHabeHunger54
IchHabeHunger54 requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@IchHabeHunger54 IchHabeHunger54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, some minor things, and some questions mainly regarding client items.

docs/blockentities/ber.md Outdated Show resolved Hide resolved
docs/resources/client/particles.md Outdated Show resolved Hide resolved
docs/resources/server/tags.md Outdated Show resolved Hide resolved
docs/resources/client/models/bakedmodel.md Outdated Show resolved Hide resolved
docs/resources/client/models/datagen.md Outdated Show resolved Hide resolved
docs/resources/client/models/items.md Show resolved Hide resolved
docs/resources/client/models/items.md Outdated Show resolved Hide resolved
docs/resources/client/models/items.md Outdated Show resolved Hide resolved
docs/resources/client/models/items.md Outdated Show resolved Hide resolved
docs/resources/client/models/items.md Outdated Show resolved Hide resolved
@ChampionAsh5357 @IchHabeHunger54
fix(docs): Apply IHH's language fixes
bb7bae6 
Co-authored-by: IchHabeHunger54 <52419336+IchHabeHunger54@users.noreply.github.com>
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 7, 2025 14:52 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 7, 2025 15:16 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 7, 2025 18:20 Active
IchHabeHunger54
IchHabeHunger54 requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@IchHabeHunger54 IchHabeHunger54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, one small change please.

docs/resources/client/models/items.md Outdated Show resolved Hide resolved
@IchHabeHunger54 IchHabeHunger54 mentioned this pull request Jan 7, 2025
Merged
@ChampionAsh5357 @IchHabeHunger54
chore(docs): Word change!
a68876e 
Co-authored-by: IchHabeHunger54 <52419336+IchHabeHunger54@users.noreply.github.com>
@IchHabeHunger54 IchHabeHunger54 mentioned this pull request Jan 7, 2025
Closed
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 7, 2025 18:32 Active
@IchHabeHunger54 IchHabeHunger54 merged commit 7c42d8f into neoforged:main Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IchHabeHunger54 IchHabeHunger54 IchHabeHunger54 approved these changes

@XFactHD XFactHD Awaiting requested review from XFactHD

Assignees
No one assigned
Labels
large Major additions or changes. update Previously correct, but now outdated information.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

level attachments have been supported for a while extra face data example is false and doesnt work.
3 participants
@ChampionAsh5357 @XFactHD @IchHabeHunger54