Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networking documentation #42

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Add networking documentation #42

merged 2 commits into from
Dec 31, 2023

Conversation

marchermans
Copy link
Contributor

@marchermans marchermans commented Dec 31, 2023

This removes the documentation for simple channel, and adds at least initial documentation for the new networking framework and configuration tasks.


Preview URL: https://pr-42.neoforged-docs-previews.pages.dev

This comment was marked as duplicate.

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 31, 2023 20:39 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Dec 31, 2023

Deploying with Cloudflare Pages

Name Result
Last commit: e345f20673e57a44d03f98317bad47238dfc310e
Status: ✅ Deploy successful!
Preview URL: https://7375667b.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-42.neoforged-docs-previews.pages.dev

Copy link
Member

@IchHabeHunger54 IchHabeHunger54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Please change the headers to the new format while you're at it (since the dedicated PR for that will not catch the changes), i.e. # Header and ## Subheader instead of the === and --- header style, and change the Forge to NeoForge, then I think we can ship this.

docs/networking/index.md Outdated Show resolved Hide resolved
Copy link
Member

@IchHabeHunger54 IchHabeHunger54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: from me

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 31, 2023 20:56 Active
@marchermans marchermans merged commit 26b08cd into main Dec 31, 2023
1 check passed
@marchermans marchermans deleted the documentation/neoforged branch December 31, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants