Conversation
Matyrobbrt
added
enhancement
Last commit published: 3a52fde222cd23130ec02a9d6385e115487603e4. PR PublishingThe artifacts published by this PR:Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #9' // https://github.com/neoforged/JavaSourceTransformer/pull/9
url 'https://prmaven.neoforged.net/JavaSourceTransformer/pr9'
content {
includeModule('net.neoforged.jst', 'jst-cli-bundle')
includeModule('net.neoforged.jst', 'jst-cli')
}
}
} |
shartte
reviewed
Apr 17, 2024
accesstransformers/src/main/java/net/neoforged/jst/accesstransformers/ATsPlugin.java
Show resolved
Hide resolved
accesstransformers/src/main/java/net/neoforged/jst/accesstransformers/ATsTransformer.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class ATsTransformer implements SourceTransformer { | ||
|
|
||
| @CommandLine.Option(names = "--access-transformer", required = true) |
Contributor
There was a problem hiding this comment.
Are you sure about required=true here?
Member
Author
There was a problem hiding this comment.
I have no idea how it works with lists actually, I need to test it.
accesstransformers/src/main/java/net/neoforged/jst/accesstransformers/ApplyATsVisitor.java
Outdated
Show resolved
Hide resolved
accesstransformers/src/main/java/net/neoforged/jst/accesstransformers/ApplyATsVisitor.java
Show resolved
Hide resolved
shartte
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows not running decomp again when changing an AT.