-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker image #81
base: master
Are you sure you want to change the base?
Add docker image #81
Changes from 1 commit
435eb16
5f766b9
a163d75
b32a8fb
00b6247
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
FROM python:3.7 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Try to get familiar with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've used hadolint to format the Dockerfile accordingly :) |
||
RUN apt-get update && apt-get install -y git | ||
|
||
RUN git clone https://github.com/neomatrix369/nlp_profiler.git | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of doing this try to see if you can actually use the local folder and the code downloaded in it - there is an advantage and purpose for doing it. See how it has been done here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for the suggestion Mani. I've updated the file so it uses the local folder. |
||
|
||
WORKDIR nlp_profiler | ||
|
||
ADD app.py . | ||
|
||
RUN pip install -r requirements-dev.txt | ||
|
||
RUN pip install -r requirements.txt | ||
|
||
RUN pip install -r requirements-nix-dev.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if you can make this python version configurable that you can pass it via the shell script or environment variable.
If you look into the docker shell scripts in any of these examples here, you can see how it's done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing this out. I've updated the Dockerfile to pass the argument via the shell script.