Skip to content

Commit

Permalink
Skip dropping tablesync replication slots on the publisher from branch (
Browse files Browse the repository at this point in the history
#11073)

fixes neondatabase/cloud#24292

Do not drop tablesync replication slots on the publisher, 
when we're in the process of dropping subscriptions inherited by a neon
branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE
before calling DROP SUBSCRIPTION, but tablesync slots are not exposed to
SQL.

rely on GUC disable_logical_replication_subscribers=true 
to know that we're in the Neon-specific process of dropping
subscriptions.
  • Loading branch information
lubennikovaav authored Mar 5, 2025
1 parent 40aa4d7 commit 38a8831
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion vendor/postgres-v14
2 changes: 1 addition & 1 deletion vendor/postgres-v15
2 changes: 1 addition & 1 deletion vendor/postgres-v16
2 changes: 1 addition & 1 deletion vendor/postgres-v17
8 changes: 4 additions & 4 deletions vendor/revisions.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"v17": [
"17.4",
"517b8dc244abf3e56f0089849e464af76f70b94e"
"780efda2ef8d629495cc289624534ba8cde40779"
],
"v16": [
"16.8",
"799e7a08dd171aa06a7395dd326f4243aaeb9f93"
"78050f965f2e550fd6e58f837394cb3d080d7d42"
],
"v15": [
"15.12",
"9b118b1cffa6e4ca0d63389b57b54d11e207e9a8"
"533be42f7da97e614ce1c494fafe3e49f53991b1"
],
"v14": [
"14.17",
"6254ab9b4496c3e481bc037ae69d859bbc2bdd7d"
"b1425505c6f9a622a5aadf3ee362740519993310"
]
}

1 comment on commit 38a8831

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7940 tests run: 7552 passed, 0 failed, 388 skipped (full report)


Code coverage* (full report)

  • functions: 32.9% (8684 of 26416 functions)
  • lines: 48.8% (73988 of 151542 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
38a8831 at 2025-03-05T15:22:38.743Z :recycle:

Please sign in to comment.