Skip to content

Commit

Permalink
add todos
Browse files Browse the repository at this point in the history
Signed-off-by: Alex Chi Z <chi@neon.tech>
  • Loading branch information
skyzh committed Apr 24, 2024
1 parent 021872b commit 804ea39
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pageserver/src/tenant/timeline.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3964,7 +3964,7 @@ impl Timeline {
let img_range = start..partition.ranges.last().unwrap().end;

if partition.overlaps(&Key::metadata_key_range()) {
// The next patch will correctly create image layers for metadata keys, and it would be a
// TODO(chi): The next patch will correctly create image layers for metadata keys, and it would be a
// rather big change. Keep this patch small for now.
match mode {
ImageLayerCreationMode::Force | ImageLayerCreationMode::Try => {
Expand Down
2 changes: 1 addition & 1 deletion pageserver/src/tenant/timeline/compaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ impl Timeline {
}

let (dense_ks, _sparse_ks) = self.collect_keyspace(end_lsn, ctx).await?;
// ignore sparse_keyspace for now, compact it in the future.
// TODO(chi): ignore sparse_keyspace for now, compact it in the future.
let mut adaptor = TimelineAdaptor::new(self, (end_lsn, dense_ks));

pageserver_compaction::compact_tiered::compact_tiered(
Expand Down

0 comments on commit 804ea39

Please sign in to comment.