Skip to content

Commit

Permalink
Draft fix for #10381
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexanderlaw
alexanderlaw committed Jan 18, 2025
1 parent 531ad93 commit ee17ff0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test_runner/fixtures/pageserver/allowed_errors.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def scan_pageserver_log_for_errors(
# During teardown, we stop the storage controller before the pageservers, so pageservers
# can experience connection errors doing background deletion queue work.
".*WARN deletion backend: calling control plane generation validation API failed.*error sending request.*",
".*WARN init_tenant_mgr: calling control plane generation validation API failed.*error sending request.*",
# Can happen when the test shuts down the storage controller while it is calling the utilization API
".*WARN.*path=/v1/utilization .*request was dropped before completing",
# Can happen during shutdown
Expand Down

1 comment on commit ee17ff0

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1328 tests run: 1165 passed, 85 failed, 78 skipped (full report)

Failures on Postgres 17

  • test_backward_compatibility: debug-x86-64, debug-arm64
  • test_forward_compatibility: debug-x86-64, debug-arm64
  • test_versions_mismatch[combination_nnnnn]: debug-x86-64, debug-arm64
  • test_versions_mismatch[combination_ooonn]: debug-x86-64, debug-arm64
  • test_versions_mismatch[combination_ononn]: debug-x86-64, debug-arm64
  • test_versions_mismatch[combination_onnnn]: debug-x86-64, debug-arm64
  • test_versions_mismatch[combination_nnnoo]: debug-x86-64, debug-arm64
  • test_partial_evict_tenant[relative_spare]: debug-arm64
  • test_pageserver_evicts_until_pressure_is_relieved[relative_equal]: debug-arm64
  • test_broken_tenants_are_skipped: debug-arm64
  • test_pageserver_falls_back_to_global_lru[relative_equal]: debug-arm64
  • test_pageserver_respects_overridden_resident_size[relative_equal]: debug-arm64
  • test_partial_evict_tenant[relative_equal]: debug-arm64
  • test_secondary_mode_eviction: debug-arm64
  • test_statvfs_pressure_usage: debug-arm64
  • test_statvfs_error_handling: debug-arm64
  • test_statvfs_pressure_min_avail_bytes: debug-arm64
  • test_hot_standby_feedback: debug-arm64
  • test_sliding_working_set_approximation: debug-arm64
  • test_on_demand_wal_download: debug-arm64
  • test_pageserver_getpage_throttle: debug-arm64
  • test_pageserver_restarts_under_worload: debug-arm64
  • test_pageserver_reconnect: debug-arm64
  • test_isolation[None]: debug-arm64
  • test_isolation[4]: debug-arm64
  • test_cancellations: debug-arm64
  • test_storage_controller_node_deletion[True]: debug-x86-64, debug-arm64
  • test_storage_controller_metadata_health[2]: debug-arm64
  • test_storage_controller_validate_during_migration: debug-arm64
  • test_storage_controller_proxy_during_migration[MigrationFailpoints.PRE_GENERATION_INC]: debug-arm64
  • test_tenant_import[4-real_s3]: debug-arm64
  • test_storage_controller_metadata_health[None]: debug-arm64
  • test_multi_attached_timeline_creation[MigrationFailpoints.POST_NOTIFY]: debug-arm64
  • test_storage_controller_detached_stopped: debug-arm64
  • test_tenant_import[None-real_s3]: debug-arm64
  • test_storage_controller_proxy_during_migration[MigrationFailpoints.POST_NOTIFY]: debug-arm64
  • test_storage_controller_proxy_during_migration[MigrationFailpoints.POST_DETACH]: debug-arm64
  • test_storage_controller_node_deletion[False]: debug-arm64
  • test_storage_controller_onboard_detached: debug-arm64
  • test_storage_controller_detach_lifecycle: debug-arm64
  • test_storage_controller_onboarding[False]: debug-arm64
  • test_scrubber_tenant_snapshot[None]: debug-arm64
  • test_scrubber_physical_gc_ancestors[None]: debug-arm64
  • test_scrubber_physical_gc_timeline_deletion: debug-arm64
  • test_scrubber_tenant_snapshot[4]: debug-arm64
  • test_scrubber_physical_gc[None]: debug-arm64
  • test_scrubber_physical_gc[4]: debug-arm64
  • test_scrubber_physical_gc_ancestors[2]: debug-arm64
  • test_scrubber_physical_gc_ancestors_split: debug-arm64
  • test_scrubber_scan_pageserver_metadata[4]: debug-arm64
  • test_scrubber_scan_pageserver_metadata[None]: debug-arm64
  • test_tenant_delete_smoke: debug-arm64
  • test_tenant_delete_stale_shards: debug-arm64
  • test_create_churn_during_restart: debug-arm64
  • test_timeline_offload_persist[False]: debug-arm64
  • test_timeline_retain_lsn[offload-corrupt-False]: debug-arm64
  • test_timeline_offload_persist[True]: debug-arm64
  • test_timeline_retain_lsn[offload-corrupt-True]: debug-arm64
  • test_timeline_offload_generations: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITH_RESTART-timeline-delete-before-index-deleted-at]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-timeline-delete-before-index-deleted-at]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-timeline-delete-before-rm]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITH_RESTART-timeline-delete-before-schedule]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-timeline-delete-after-rm]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-timeline-delete-before-index-delete]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-timeline-delete-before-schedule]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-timeline-delete-after-index-delete]: debug-arm64
  • test_timeline_delete_works_for_remote_smoke: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITH_RESTART-timeline-delete-before-rm]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITH_RESTART-timeline-delete-after-rm]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITH_RESTART-timeline-delete-before-index-delete]: debug-arm64
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITH_RESTART-timeline-delete-after-index-delete]: debug-arm64
  • test_timeline_delete_resumed_on_attach: debug-arm64
  • test_wal_backup: debug-arm64
  • test_check_visibility_map: debug-arm64
  • test_wal_restore_http[False]: debug-arm64
  • test_wal_restore_http[True]: debug-arm64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_backward_compatibility[debug-pg17] or test_backward_compatibility[debug-pg17] or test_forward_compatibility[debug-pg17] or test_forward_compatibility[debug-pg17] or test_versions_mismatch[debug-pg17-combination_nnnnn] or test_versions_mismatch[debug-pg17-combination_nnnnn] or test_versions_mismatch[debug-pg17-combination_ooonn] or test_versions_mismatch[debug-pg17-combination_ooonn] or test_versions_mismatch[debug-pg17-combination_ononn] or test_versions_mismatch[debug-pg17-combination_ononn] or test_versions_mismatch[debug-pg17-combination_onnnn] or test_versions_mismatch[debug-pg17-combination_onnnn] or test_versions_mismatch[debug-pg17-combination_nnnoo] or test_versions_mismatch[debug-pg17-combination_nnnoo] or test_partial_evict_tenant[debug-pg17-relative_spare] or test_pageserver_evicts_until_pressure_is_relieved[debug-pg17-relative_equal] or test_broken_tenants_are_skipped[debug-pg17] or test_pageserver_falls_back_to_global_lru[debug-pg17-relative_equal] or test_pageserver_respects_overridden_resident_size[debug-pg17-relative_equal] or test_partial_evict_tenant[debug-pg17-relative_equal] or test_secondary_mode_eviction[debug-pg17] or test_statvfs_pressure_usage[debug-pg17] or test_statvfs_error_handling[debug-pg17] or test_statvfs_pressure_min_avail_bytes[debug-pg17] or test_hot_standby_feedback[debug-pg17] or test_sliding_working_set_approximation[debug-pg17] or test_on_demand_wal_download[debug-pg17] or test_pageserver_getpage_throttle[debug-pg17] or test_pageserver_restarts_under_worload[debug-pg17] or test_pageserver_reconnect[debug-pg17] or test_isolation[debug-pg17-None] or test_isolation[debug-pg17-4] or test_cancellations[debug-pg17] or test_storage_controller_node_deletion[debug-pg17-True] or test_storage_controller_node_deletion[debug-pg17-True] or test_storage_controller_metadata_health[debug-pg17-2] or test_storage_controller_validate_during_migration[debug-pg17] or test_storage_controller_proxy_during_migration[debug-pg17-MigrationFailpoints.PRE_GENERATION_INC] or test_tenant_import[debug-pg17-4-real_s3] or test_storage_controller_metadata_health[debug-pg17-None] or test_multi_attached_timeline_creation[debug-pg17-MigrationFailpoints.POST_NOTIFY] or test_storage_controller_detached_stopped[debug-pg17] or test_tenant_import[debug-pg17-None-real_s3] or test_storage_controller_proxy_during_migration[debug-pg17-MigrationFailpoints.POST_NOTIFY] or test_storage_controller_proxy_during_migration[debug-pg17-MigrationFailpoints.POST_DETACH] or test_storage_controller_node_deletion[debug-pg17-False] or test_storage_controller_onboard_detached[debug-pg17] or test_storage_controller_detach_lifecycle[debug-pg17] or test_storage_controller_onboarding[debug-pg17-False] or test_scrubber_tenant_snapshot[debug-pg17-None] or test_scrubber_physical_gc_ancestors[debug-pg17-None] or test_scrubber_physical_gc_timeline_deletion[debug-pg17] or test_scrubber_tenant_snapshot[debug-pg17-4] or test_scrubber_physical_gc[debug-pg17-None] or test_scrubber_physical_gc[debug-pg17-4] or test_scrubber_physical_gc_ancestors[debug-pg17-2] or test_scrubber_physical_gc_ancestors_split[debug-pg17] or test_scrubber_scan_pageserver_metadata[debug-pg17-4] or test_scrubber_scan_pageserver_metadata[debug-pg17-None] or test_tenant_delete_smoke[debug-pg17] or test_tenant_delete_stale_shards[debug-pg17] or test_create_churn_during_restart[debug-pg17] or test_timeline_offload_persist[debug-pg17-False] or test_timeline_retain_lsn[debug-pg17-offload-corrupt-False] or test_timeline_offload_persist[debug-pg17-True] or test_timeline_retain_lsn[debug-pg17-offload-corrupt-True] or test_timeline_offload_generations[debug-pg17] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITH_RESTART-timeline-delete-before-index-deleted-at] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITHOUT_RESTART-timeline-delete-before-index-deleted-at] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITHOUT_RESTART-timeline-delete-before-rm] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITH_RESTART-timeline-delete-before-schedule] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITHOUT_RESTART-timeline-delete-after-rm] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITHOUT_RESTART-timeline-delete-before-index-delete] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITHOUT_RESTART-timeline-delete-before-schedule] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITHOUT_RESTART-timeline-delete-after-index-delete] or test_timeline_delete_works_for_remote_smoke[debug-pg17] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITH_RESTART-timeline-delete-before-rm] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITH_RESTART-timeline-delete-after-rm] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITH_RESTART-timeline-delete-before-index-delete] or test_delete_timeline_exercise_crash_safety_failpoints[debug-pg17-Check.RETRY_WITH_RESTART-timeline-delete-after-index-delete] or test_timeline_delete_resumed_on_attach[debug-pg17] or test_wal_backup[debug-pg17] or test_check_visibility_map[debug-pg17] or test_wal_restore_http[debug-pg17-False] or test_wal_restore_http[debug-pg17-True]"
Flaky tests (28)

Postgres 17

Test coverage report is not available

The comment gets automatically updated with the latest test results
ee17ff0 at 2025-01-18T15:18:34.442Z :recycle:

Please sign in to comment.