Skip to content

Commit

Permalink
Check that TERM != dumb before using colors in pre-commit.py
Browse files Browse the repository at this point in the history
Signed-off-by: Tristan Partin <tristan@neon.tech>
  • Loading branch information
tristan957 committed Aug 22, 2024
1 parent 2f8d548 commit f7ab3ff
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pre-commit.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import argparse
import enum
import os
import subprocess
import sys
from typing import List
Expand Down Expand Up @@ -93,7 +94,7 @@ def check(name: str, suffix: str, cmd: str, changed_files: List[str], no_color:
"--no-color",
action="store_true",
help="disable colored output",
default=not sys.stdout.isatty(),
default=not sys.stdout.isatty() or os.getenv("TERM") == "dumb",
)
args = parser.parse_args()

Expand Down

1 comment on commit f7ab3ff

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3847 tests run: 3728 passed, 3 failed, 116 skipped (full report)


Failures on Postgres 16

  • test_compaction_l0_memory[github-actions-selfhosted]: release
  • test_pgbench_intensive_init_workload[vanilla-github-actions-selfhosted-1000]: release
  • test_heavy_write_workload[neon_off-github-actions-selfhosted-10-5-5]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_compaction_l0_memory[release-pg16-github-actions-selfhosted] or test_pgbench_intensive_init_workload[vanilla-release-pg16-github-actions-selfhosted-1000] or test_heavy_write_workload[neon_off-release-pg16-github-actions-selfhosted-10-5-5]"
Flaky tests (2)

Postgres 16

Code coverage* (full report)

  • functions: 32.4% (7238 of 22342 functions)
  • lines: 50.4% (58562 of 116176 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f7ab3ff at 2024-08-23T01:03:09.354Z :recycle:

Please sign in to comment.