pageserver: add page_trace API for debugging
#10293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7315 tests run: 6939 passed, 0 failed, 376 skipped (full report)Flaky tests (3)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
6a3dd3a at 2025-01-15T17:05:26.344Z :recycle: |
problame
requested changes
Jan 7, 2025
problame
reviewed
Jan 7, 2025
problame
reviewed
Jan 7, 2025
|
@problame I cleaned this up a bit, should be ready for final review. |
erikgrinaker
force-pushed
the
jcsp/pagetrace
branch
from
6a4115a to
c6e89d0
Compare
|
@jcsp I can't request a review from you (since you're the author), but if you could give this an LGTM I can merge based on my approval. |
problame
requested changes
Jan 15, 2025
problame
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a pageserver is receiving high rates of requests, we don't have a good way to efficiently discover what the client's access pattern is.
Closes: #10275
Summary of changes
/v1/tenant/x/timeline/y/page_trace?size_limit_bytes=...&time_limit_secs=...API, which returns a binary buffer.pagectl page-tracetool to decode and analyze the output.