Optimize vector get last written LSN #10360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7304 tests run: 6933 passed, 0 failed, 371 skipped (full report)Flaky tests (2)Postgres 17
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
ad90824 at 2025-01-13T21:14:26.565Z :recycle: |
knizhnik
force-pushed
the
lwlsn_optimization
branch
from
d440db5 to
18d5e15
Compare
MMeent
requested changes
Jan 13, 2025
added 2 commits
January 13, 2025 19:09
MMeent
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #10281
pg17 performs extra lock/unlock operation when fetching LwLSN.
Summary of changes
Perform all lookups under one lock, moving initialization of not found keys to separate loop.
Related Postgres PR:
neondatabase/postgres#553