Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sanitizers for postgres v17 #10401

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

alexanderlaw
Copy link
Contributor

Add a build with sanitizers (asan, ubsan) to the CI pipeline and run tests on it.

See #6053

Copy link

github-actions bot commented Jan 15, 2025

7414 tests run: 7063 passed, 0 failed, 351 skipped (full report)


Flaky tests (8)

Postgres 17

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 33.4% (8508 of 25499 functions)
  • lines: 49.1% (71452 of 145541 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0ac2f2a at 2025-01-30T09:15:17.611Z :recycle:

@alexanderlaw alexanderlaw force-pushed the enable-sanitizers-for-v17 branch from eceae41 to 414930a Compare January 15, 2025 09:41
pgxn/neon/walproposer.c Outdated Show resolved Hide resolved
@alexanderlaw alexanderlaw force-pushed the enable-sanitizers-for-v17 branch 2 times, most recently from cdfd9e7 to e956d9a Compare January 15, 2025 10:42
storage_controller/Cargo.toml Outdated Show resolved Hide resolved
pgxn/neon/file_cache.c Outdated Show resolved Hide resolved
@alexanderlaw alexanderlaw force-pushed the enable-sanitizers-for-v17 branch 2 times, most recently from 999686c to aafd0c8 Compare January 15, 2025 13:11
@alexanderlaw alexanderlaw requested a review from a team as a code owner January 15, 2025 13:11
@alexanderlaw alexanderlaw force-pushed the enable-sanitizers-for-v17 branch 16 times, most recently from 555aeae to a4765cd Compare January 16, 2025 15:05
@alexanderlaw alexanderlaw changed the base branch from main to fix-C-code-to-satisfy-sanitizers January 22, 2025 08:33
@alexanderlaw alexanderlaw force-pushed the enable-sanitizers-for-v17 branch from 7b12643 to 3b2d052 Compare January 22, 2025 08:34
@alexanderlaw alexanderlaw force-pushed the fix-C-code-to-satisfy-sanitizers branch from 7e9d7c9 to cc18b86 Compare January 23, 2025 12:03
@alexanderlaw alexanderlaw force-pushed the enable-sanitizers-for-v17 branch 5 times, most recently from 3d99564 to 592eeca Compare January 24, 2025 11:04
@alexanderlaw alexanderlaw force-pushed the fix-C-code-to-satisfy-sanitizers branch from cc18b86 to be6af82 Compare January 27, 2025 07:34
@alexanderlaw alexanderlaw force-pushed the enable-sanitizers-for-v17 branch 2 times, most recently from 082a7d3 to 16846db Compare January 28, 2025 04:26
Base automatically changed from fix-C-code-to-satisfy-sanitizers to main January 29, 2025 10:06
@alexanderlaw alexanderlaw force-pushed the enable-sanitizers-for-v17 branch from 16846db to 6880ac8 Compare January 29, 2025 10:40
@alexanderlaw alexanderlaw marked this pull request as ready for review January 29, 2025 10:41
@alexanderlaw alexanderlaw changed the title WIP: Enable sanitizers for v17 Enable sanitizers for postgres v17 Jan 29, 2025
@@ -32,14 +32,15 @@
flaky BOOLEAN NOT NULL,
arch arch DEFAULT 'X64',
lfc BOOLEAN DEFAULT false NOT NULL,
sanitizers BOOLEAN DEFAULT false NOT NULL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added sanitizers column to the db (it's false by default), could you please add setting it from test results?
You can use LFC as an example, you need to add changes to scripts/ingest_regress_test_result-new-format.py and test_runner/fixtures/parametrize.py and maybe to workflow to set this env variable for test runs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at a commit I've added to address this: 0ac2f2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants