-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pageserver): generate image layers for sparse keyspace #7567
Conversation
3102 tests run: 2975 passed, 0 failed, 127 skipped (full report)Flaky tests (4)Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
58c801c at 2024-05-20T16:18:29.609Z :recycle: |
4229426
to
5d9ba8b
Compare
007423d
to
03c5484
Compare
For reference, this is the log of test_metadata_scan, where image layer generation happens and L0 compaction works correctly. |
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@arpad-m @VladLazar comments resolved and ready for review, thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really like to avoid adding something to the request context that is only needed for compaction. I've got one suggestion here.
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
should be ready for review and wait for CI runs... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Problem
Part of #7462
Sparse keyspace does not generate image layers for now. This pull request adds support for generating image layers for sparse keyspace.
Summary of changes
Know issue: the scan interface currently reads past the image layer, which causes
delta_layer_accessed
keeps increasing even if image layers are generated. The pull request to fix that will be separate, and orthogonal to this one.Checklist before requesting a review
Checklist before merging