Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bodobolero/fix root permissions #8429

Merged
merged 18 commits into from
Jul 19, 2024
Merged

Conversation

Bodobolero
Copy link
Contributor

@Bodobolero Bodobolero commented Jul 19, 2024

Problem

My prior PR #8422
caused leftovers in the GitHub action runner work directory with root permission.
As an example see here https://github.com/neondatabase/neon/actions/runs/10001857641/job/27646237324#step:3:37
To work-around we install vanilla postgres as non-root using deb packages in /home/nonroot user directory

Summary of changes

  • since we cannot use root we install the deb pkgs directly and create symbolic links for psql, pgbench and libs in expected places
  • continue jobs an aws even if azure jobs fail (because this region is currently unreliable)

@Bodobolero Bodobolero requested a review from a-masterov July 19, 2024 09:06
Copy link

github-actions bot commented Jul 19, 2024

3126 tests run: 3005 passed, 0 failed, 121 skipped (full report)


Code coverage* (full report)

  • functions: 32.7% (6994 of 21386 functions)
  • lines: 50.2% (55235 of 110136 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7597724 at 2024-07-19T13:44:58.006Z :recycle:

.github/workflows/benchmarking.yml Outdated Show resolved Hide resolved
.github/workflows/benchmarking.yml Outdated Show resolved Hide resolved
.github/workflows/benchmarking.yml Outdated Show resolved Hide resolved
.github/workflows/benchmarking.yml Outdated Show resolved Hide resolved
.github/workflows/benchmarking.yml Outdated Show resolved Hide resolved
.github/workflows/benchmarking.yml Outdated Show resolved Hide resolved
.github/workflows/benchmarking.yml Outdated Show resolved Hide resolved
@Bodobolero Bodobolero enabled auto-merge (squash) July 19, 2024 13:27
@Bodobolero Bodobolero merged commit 392d352 into main Jul 19, 2024
64 checks passed
@Bodobolero Bodobolero deleted the bodobolero/fix_root_permissions branch July 19, 2024 13:40
problame pushed a commit that referenced this pull request Jul 22, 2024
## Problem

My prior PR #8422
caused leftovers in the GitHub action runner work directory with root
permission.
As an example see here
https://github.com/neondatabase/neon/actions/runs/10001857641/job/27646237324#step:3:37
To work-around we install vanilla postgres as non-root using deb
packages in /home/nonroot user directory

## Summary of changes

- since we cannot use root we install the deb pkgs directly and create
symbolic links for psql, pgbench and libs in expected places
- continue jobs an aws even if azure jobs fail (because this region is
currently unreliable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants