Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL minor version updates (17.1, 16.5, 15.9, 14.14) #9727

Merged
merged 1 commit into from
Nov 13, 2024
Merged

PostgreSQL minor version updates (17.1, 16.5, 15.9, 14.14) #9727

merged 1 commit into from
Nov 13, 2024
+54 −12

Conversation

hlinnaka
Copy link
Contributor

@hlinnaka hlinnaka requested a review from a team as a code owner November 12, 2024 07:56
@hlinnaka
Copy link
Contributor Author

There were no significant conflicts

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

5391 tests run: 5171 passed, 0 failed, 220 skipped (full report)

Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.8% (7889 of 24834 functions)
  • lines: 49.5% (62436 of 126257 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
5a0f8c6 at 2024-11-13T10:04:21.981Z :recycle:

@lubennikovaav lubennikovaav added the /release-notes Release notes content label Nov 12, 2024
lubennikovaav
lubennikovaav approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@lubennikovaav lubennikovaav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
(I didn't dig deep into the list of upstream changes)

@tristan957
Copy link
Member

Did you cherry-pick https://gitlab.com/dalibo/postgresql_anonymizer/-/commit/23aac2f78ef5926722cc38f34f448d51fbf3673b for the timezone issue?

@hlinnaka
Copy link
Contributor Author

Did you cherry-pick https://gitlab.com/dalibo/postgresql_anonymizer/-/commit/23aac2f78ef5926722cc38f34f448d51fbf3673b for the timezone issue?

I'm getting the failure with vanilla Postgres and vanilla postgresql_anonymizer checkout that includes that commit. I believe that fix was insufficient.

Good point that we're missing that in our version of pg_anon though. That means that the patch that I included here probably won't work.

@hlinnaka
Copy link
Contributor Author

Good point that we're missing that in our version of pg_anon though. That means that the patch that I included here probably won't work.

It did apply anyway, so we're good.

@hlinnaka
PostgreSQL minor version updates (17.1, 16.5, 15.9, 14.14)
5a0f8c6 
This includes a patch to temporarily disable one test in the pg_anon
test suite. It is an upstream issue, the test started failing with the
new PostgreSQL minor versions because of a change in the default
timezone used in tests. We don't want to block the release for this,
so just disable the test for now. See
https://gitlab.com/dalibo/postgresql_anonymizer/-/commit/199f0a392b37c59d92ae441fb8f037e094a11a52#note_2148017485
@hlinnaka hlinnaka merged commit 10aaa36 into main Nov 13, 2024
84 checks passed
@hlinnaka hlinnaka deleted the minor-updates branch November 13, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubennikovaav lubennikovaav lubennikovaav approved these changes

@MMeent MMeent MMeent approved these changes

@kelvich kelvich Awaiting requested review from kelvich kelvich is a code owner automatically assigned from neondatabase/compute

@ololobus ololobus Awaiting requested review from ololobus

@tristan957 tristan957 Awaiting requested review from tristan957

Assignees
No one assigned
Labels
/release-notes Release notes content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlinnaka @tristan957 @MMeent @lubennikovaav