Skip to content

add: signup 구현 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Song-H-H wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add: signup 구현 #45

Song-H-H wants to merge 1 commit into from

Conversation

@Song-H-H
Copy link
Contributor

@Song-H-H Song-H-H commented Nov 25, 2022

  • user serivce 추가
  • exceptionhandler 추가

@Song-H-H
add: user service 추가
cf3df29 
     exceptionhandler 추가
     signup 구현
clemado1
clemado1 reviewed Nov 30, 2022
View reviewed changes
src/main/java/com/neorang/neims/users/service/UserSerivce.java

Users user = signupForm.toEntity();
user.setPassword(encodePassword);
user.setRole(Role.USER);
Copy link
Member

@clemado1 clemado1 Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필수 값 Assert 및 사용자 권한 기본값은 도메인의 책임이 더 크므로 SignupForm으로 이동, 혹은 Validation 적용

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clemado1 clemado1 clemado1 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Song-H-H @clemado1