Implement #75 - Command Line Argument parsing utility and config #96
Conversation
XDelta
added
enhancement
| private static readonly string[] possibleNeosExactFlagArguments = | ||
| { | ||
| "ctaa", "ctaatemporaledgepower", "ctaasharpnessenabled", "ctaaadaptivesharpness", "ForceSRAnipal", | ||
| "StereoDisplay", "MixedReality", "DirectComposition", "ExternalComposition", "create_mrc_config", | ||
| "load_mrc_config" | ||
| }; | ||
|
|
||
| private static readonly string[] possibleNeosExactParameterArguments = | ||
| { | ||
| "TextureSizeRatio", "DataPath", "CachePath" | ||
| }; | ||
|
|
||
| private static readonly string[] possibleNeosInfixFlagArguments = | ||
| { | ||
| "CameraBiggestGroup", "CameraTimelapse", "CameraStayBehind", "CameraStayInFront", "AnnounceHomeOnLAN" | ||
| }; | ||
|
|
||
| private static readonly string[] possibleNeosSuffixFlagArguments = | ||
| { | ||
| "GeneratePrecache", "Verbose", "pro", "UseLocalCloud", "UseStagingCloud", "ForceRelay", "Invisible", | ||
| "ForceReticleAboveHorizon", "ForceNoVoice", "ResetDash", "Kiosk", "DontAutoOpenCloudHome", "ResetUserspace", | ||
| "ForceLANOnly", "DeleteUnsyncedCloudRecords", "ForceSyncConflictingCloudRecords", "ForceIntroTutorial", | ||
| "SkipIntroTutorial", "RepairDatabase", "UseNeosCamera", "LegacySteamVRInput", "Etee", "HideScreenReticle", | ||
| "Viveport", "DisableNativeTextureUpload" | ||
| }; | ||
|
|
||
| private static readonly string[] possibleNeosSuffixParameterArguments = | ||
| { | ||
| "Config", "LoadAssembly", "BackgroundWorkers", "PriorityWorkers", "Bench", "Watchdog", "Bootstrap", | ||
| "OnlyHost", "Join", "Open", "OpenUnsafe", "EnableOWO" | ||
| }; |
There was a problem hiding this comment.
I don't think it's a good idea to rely on a list of Neos arguments. They can and will be changed if Neos ever gets updated again. NML should not be concerned with these, and if a mod is concerned with one, they could easily implement their own check for it IMO.
There was a problem hiding this comment.
I wanted to do only -NML. ones first, but then I was like... it'd be kinda nice to know if an upcoming one is part of the Neos ones - and then I might as well just expose them. They're also important to know for mod creators wanting to add their own, as there's a lot of them that block any other argument ending with them or even containing them
| var parsedValue = TypeDescriptor.GetConverter(possibleProperty.PropertyType).ConvertFromInvariantString(value); | ||
| possibleProperty.SetValue(config, parsedValue); | ||
|
|
||
| Logger.MsgInternal($"Loaded value for {possibleProperty.Name} from file: {parsedValue}"); |
There was a problem hiding this comment.
I imagine this'd be rather spammy too?
There was a problem hiding this comment.
It basically lists all the values that have been set - could make this Debug, but enabling debug may only happen after this...
| public bool ExposeLateTypes | ||
| { | ||
| if (_configuration == null) | ||
| { | ||
| // the config file can just sit next to the dll. Simple. | ||
| string path = Path.Combine(GetAssemblyDirectory(), CONFIG_FILENAME); | ||
| _configuration = new ModLoaderConfiguration(); | ||
| get => !HideLateTypes; | ||
| set => HideLateTypes = !value; | ||
| } | ||
|
|
||
| public bool ExposeModTypes | ||
| { | ||
| get => !HideModTypes; | ||
| set => HideModTypes = !value; | ||
| } | ||
|
|
||
| public bool HideConflicts | ||
| { | ||
| get => !LogConflicts; | ||
| set => LogConflicts = !value; | ||
| } |
There was a problem hiding this comment.
...is there an actual reason to duplicate these...?
There was a problem hiding this comment.
Added some inverted properties to allow setting them with flag arguments.
| /// Contains methods to access the command line arguments Neos was launched with. | ||
| /// </summary> | ||
| /// Use analyze on Environment.GetCommandLineArgs() to find all possible arguments. | ||
| public static class LaunchArguments |
There was a problem hiding this comment.
Just overall to me this seems like a solution looking for a problem ¯\_(ツ)_/¯
|
maybe instead of putting all the neos default argument parsing code inside of the loader itself, it would be better to create a library mod that can be used by other mods? we have Libraries category in the manifest that seems like it would be perfect for this |
hey, doing the config parsing "manually" is @zkxs's doing. I've used an ini Parser in the SpotifyStatus server, but that's another library and also only parses it into a string dictionary style afaik
but if it's a library I can't use it for NML's config 😝 |
Implements an expanded upon Version of the feature requested by @art0007i in #75.
Also changed config loading to use reflection to make it more compact, more permissive and easy to add new values.
Added some inverted properties to allow setting them with flag arguments.