BUGFIX: add 'validationErrorMessage' as a supported option #3133
Conversation
|
Thanks for the fix. Is this bug related too Neos 9? otherwise the PR should target the Neos 7.3 branch. |
|
Create new PR on 7.3 branch here: #3134 |
|
If the aim is to change the error message, there are plenty of possibilities. You could use the code and provide an own translation. Or you could override the translation flow provides. Why would you have the message changeable for each validator instance? |
| @@ -24,7 +24,8 @@ class RegularExpressionValidator extends AbstractValidator | |||
| * @var array | |||
| */ | |||
| protected $supportedOptions = [ | |||
| 'regularExpression' => ['', 'The regular expression to use for validation, used as given', 'string', true] | |||
| 'regularExpression' => ['', 'The regular expression to use for validation, used as given', 'string', true], | |||
| 'validationErrorMessage' => ['', 'The error message to show for validation, if the regular expression validation fails', 'string', false] | |||
There was a problem hiding this comment.
This is only enough to fullfill the needs of the Neos validation system so we do not get an exception here, but in fact this new supported option should impact eg.
https://github.com/neos/flow-development-collection/pull/3133/files#diff-2ecda0a3f7d78fb28fd5cffe20976014c4281e728f4193e505844d380144e9f1R43
otherwise it makes absolutely no sense from the PHP side of things, as nothing happens when I set this option.
Add 'validationErrorMessage' as an supported option, for the RegularExpressionValidator.
resolved: neos/neos-ui#3691
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions