DRAFT FEATURE: add 'validationErrorMessage' option #3141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Right, this makes sense to me like this, sorry commented on the closed change. |
kitsunet
reviewed
Jan 17, 2024
| @@ -487,6 +487,7 @@ Arguments | |||
| ********* | |||
|
|
|||
| * ``regularExpression`` (string): The regular expression to use for validation, used as given | |||
| * ``validationErrorMessage`` (string): The error message to show for validation, if the regular expression validation fails | |||
There was a problem hiding this comment.
This file is auto generated from the code and should be updted automatically, so no need to manually change it it, that might just lead to errors with the generator. :)
kitsunet
reviewed
Jan 17, 2024
| @@ -39,7 +40,11 @@ protected function isValid($value) | |||
| { | |||
| $result = preg_match($this->options['regularExpression'], $value); | |||
| if ($result === 0) { | |||
| $this->addError('The given subject did not match the pattern. Got: %1$s', 1221565130, [$value]); | |||
| if ($this->options['validationErrorMessage']) { | |||
| $this->addError($this->options['validationErrorMessage'], 1692962252); | |||
There was a problem hiding this comment.
I wonder (mostly a question to other team members with an opinion about this) do we not want to use the same error code here? After all it's the same error just the message is different.
|
As stated here: I would vouch for closing this and fixing it in the ui #3134 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'validationErrorMessage' option for Validators was introduced here: neos/neos-ui#2996.
But is currently unusable, see: neos/neos-ui#3691
In a first DRAFT I added 'validationErrorMessage' as an supported option, for the RegularExpressionValidator.
If this looks good, I would add the option to the other validators (adopted in Neos-UI) as well.
So please give some Feedback : )
resolved: neos/neos-ui#3691
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions