TASK: Ensure that SerializedNodeReferencesForName are serialized as…

… list
neos · Oct 31, 2024 · 4eee438 · 4eee438
1 parent 3310d74
commit 4eee438
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/...ntRepository.Core/Classes/Feature/NodeReferencing/Dto/SerializedNodeReferencesForName.php b/...ntRepository.Core/Classes/Feature/NodeReferencing/Dto/SerializedNodeReferencesForName.php
@@ -31,16 +31,16 @@
 
     private function __construct(
         public ReferenceName $referenceName,
-        SerializedNodeReference ...$references
+        SerializedNodeReference ...$items
     ) {
         $referencesByTarget = [];
-        foreach ($references as $reference) {
-            if (isset($referencesByTarget[$reference->targetNodeAggregateId->value])) {
-                throw new \InvalidArgumentException(sprintf('Duplicate entry in references to write. Target "%s" already exists in collection.', $reference->targetNodeAggregateId->value), 1700150910);
+        foreach ($items as $item) {
+            if (isset($referencesByTarget[$item->targetNodeAggregateId->value])) {
+                throw new \InvalidArgumentException(sprintf('Duplicate entry in references to write. Target "%s" already exists in collection.', $item->targetNodeAggregateId->value), 1700150910);
             }
-            $referencesByTarget[$reference->targetNodeAggregateId->value] = true;
+            $referencesByTarget[$item->targetNodeAggregateId->value] = true;
         }
-        $this->references = $references;
+        $this->references = array_values($items);
     }
 
     /**