TASK: Rewrite Neos.Neos:Shortcut to pure fusion

[mhsdesign]

The backend rendering for shortcut nodes is reimplemented in the fusion prototype Neos.Neos:Shortcut and the previous fluid template is removed.

resolves: #3261

I tested all possible backend views of the Neos.Neos:Shortcut in the Neos.Demo:

• shortcut to the parent page
• shortcut to image
• shortcut to external URI
• shortcut to specific node target / reference
• shortcut to first child page

[daniellienert]

Hey @mhsdesign,

thank you very much for working on that task!!!

I think we can shrink the fusion down and make it more readable, see my comments. Currently fusion only renders in frontend language, so we should discuss, if we should add a backendTranslationHelper instead of a BackendUserHelper.

[mhsdesign]

okay thanks for your advice ;)

i think a BackendTranslationHelper might be better too. I will work on it ;)

[mhsdesign]

Some points left - wich need to be discussed:

• i found some css in https://github.com/neos/neos-ui/blob/master/Resources/Private/Fusion/Prototypes/Shortcut.fusion
  which actually belongs to this prototype ... should i move it here then? yes -> but how without breaking things... neos/neos-ui@ec838d9 -> also inline style cheets - i was told - is not THE way

• i disabled the cache for the backend shortcut view - as it previously didnt calculate the current user language into the cache, and i figured i wouldnt cache backend modules either.

• i will remove the fallback translations soon but the 'shortcut.toSpecificTarget' (see BUG: Translations Neos.Neos:Shortcut missing and wrong HTML #3371) translation is missing. I read that Neos uses Crowdin - so can someone with access please handle that 😁

• i dont know if the BackendTranslationHelper is well written, as it extends the flow translation helper and adjusts a protected method. But this was the cleanest? way to support shorthand translation, fullparameter translation and chained translation. Otherwise one need to copy paste nearly half of the flow translation helper solved by FEATURE: Add Fusion EEL Helper ${Neos.Backend.interfaceLanguage()} #3939

[mhsdesign]

oops... crowdin is no more? #3437 (comment)

[mhsdesign]

since im extending the flow translation helper and modifing a protecteded method - this will fail silently if the flow guys rename the method. Should i implement a method_exists check in the constructor? I guess the best would be to refactor the flow translation helper to make it easily extensible.

[mhsdesign]

So i thought about this again, the fluid <neos:backend.translate> implementation:
https://github.com/neos/neos-development-collection/blob/ddf0b3f273395cb4dee316c5d0205b603abba5f7/Neos.Neos/Classes/ViewHelpers/Backend/TranslateViewHelper.php uses also inheritance and some ugly duplicated code ... id like to avoid that, but there is no simple way around that.

Similar to the fluid view helper, it would look for the eel helper like this (by @jonnitto ):
https://github.com/CarbonPackages/Carbon.Eel/blob/b2cf962d4dc367f79d41d573cc9766223ed0787a/Classes/EelHelper/BackendHelper.php

I just see inheritance in this case as not a good design choice.

code has been adjusted

[mhsdesign]

this is WIP, until #3638 is solved.

[mhsdesign]

With #3937 (waiting for upmerge) and #3371 in place, the path of my first Neos PR can continue after beeing 14 months stale! ;)

Open for reviews ;)

[mhsdesign]

Okay, #3937 is now upmerged (and available in this branch), so now it's really ready for review ;)

[mficzel]

Works as expected and and removes the fluid template.

1. The pr should start with a brief description that is suitable for the release notes like:

The backend rendering for shortcut nodes was is reimplemented via the new fusion prototype Neos.Neos:Shortcut and the previous fluid template is removed.

2. While this is pretty much an 1:1 fusion implementation. i personally would prefer to use some prototypes inside to make this extensible but consider this optional.
   It could work with a central Neos.Neos:Shortcut.Case that does the switching between Neos.Neos:Shortcut.ParentNode, Neos.Neos:Shortcut.FirstChildNode and Neos.Neos:Shortcut.SelectedTargetNode

[mhsdesign]

2. While this is pretty much an 1:1 fusion implementation. i personally would prefer to use some prototypes inside to make this extensible but consider this optional.
It could work with a central Neos.Neos:Shortcut.Case that does the switching between Neos.Neos:Shortcut.ParentNode, Neos.Neos:Shortcut.FirstChildNode and Neos.Neos:Shortcut.SelectedTargetNode

good idea (WIP at my pc) but ill wait for #3943 ;)

also those parts need to be discussed #3372 (comment)

[bwaidelich]

Thanks for this!

I agree to @mficzel's comments. Splitting this into smaller chunks would greatly enhance extensibility and readability.

good idea (WIP at my pc) but ill wait for #3943 ;)

Can we maybe get this in based on the current feature set? IMO #3943 is a great direction but it's a higher-risk-feature and it would be a pitty if it blocked this one.

Regarding

i found some css [...] should i move it here then? yes -> but how without breaking things

What about targeting 9.0 with this feature?

i disabled the cache for the backend shortcut view - as it previously didnt
calculate the current user language into the cache

Can't we add the user language to the @cache config?

[bwaidelich]

It's been a while.. Is this one still in progress?

Adjusted as requested

[mhsdesign]

Neos ui part neos/neos-ui#3657

[mficzel]

Looks good by reading and it works