TASK: Move node creation dialog stuff to the Neos.Neos.Ui #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
task/removeDeclarationOfUiNodeCreationHandler
branch
from
5d6d737 to
4ef534b
Compare
mhsdesign
force-pushed
the
task/removeDeclarationOfUiNodeCreationHandler
branch
from
4ef534b to
2341cfe
Compare
NodeType configuration, which resides in `ui.creationDialog` is part of the Neos.Neos.Ui
kitsunet
approved these changes
Feb 29, 2024
…sor` to Neos.Ui There it will reside in the `CreationDialogPostprocessor` NodeType configuration, which resides in `ui.creationDialog` is part of the Neos.Neos.Ui
... as the Neos Ui class will be named something with `PromotedElementsCreationHandler`
The translation of the `creationDialog` will also be removed as we will not require it anymore in order to fix this bug: neos/neos-ui#3509
mhsdesign
changed the title
|
Okay i was able to move all node creation stuff to the neos ui, even parts of the node type post processors: Neos.Neos/Classes/NodeTypePostprocessor/CreationDialogPostprocessor.php
|
grebaldi
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be handled in the ui neos/neos-ui#3519
I thought a lot about where the NodeCreation handlers should reside. After discussion this matter with a few people and also extensively with Wilhelm we are sure they should stay in the Neos.Ui. Thats why we move the handling over there.
All the node creation stuff will be moved to the neos ui, even parts of the node type post processors:
Neos.Neos/Classes/NodeTypePostprocessor/CreationDialogPostprocessor.php
showInCreationDialog: truelogic, moved fully to ui\Neos\Neos\Ui\Infrastructure\ContentRepository\CreationDialog\CreationDialogNodeTypePostprocessorNeos.Neos/Classes/NodeTypePostprocessor/DefaultPropertyEditorPostprocessor.php
creationDialog, this part was incorporated into theCreationDialogNodeTypePostprocessorui.creationDialogDeclarations and configurations in the node types have also been migrated.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions