!!! 4191 - Adjust and test node type change behavior #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 13, 2024 21:21
This - changes node types also recursively for tethered nodes - adds missing tethered nodes after node type change, also recursively - thoroughly cleans up disallowed children, also recursively - adds default values after node type change - removes obsolete property values after node type change
nezaniel
requested review from
mhsdesign,
bwaidelich,
skurfuerst and
kitsunet
dlubitz
reviewed
Oct 24, 2024
kitsunet
reviewed
Oct 24, 2024
Neos.ContentRepository.Core/Classes/Feature/Common/TetheredNodeInternals.php
Show resolved
Hide resolved
…ng changes for aggregates
kitsunet
reviewed
Oct 24, 2024
kitsunet
approved these changes
Oct 24, 2024
Co-authored-by: Christian Müller <christian@flownative.com>
dlubitz
approved these changes
Oct 24, 2024
mhsdesign
reviewed
Oct 30, 2024
Comment on lines
+41
to
+42
| // null for aggregate scoped changes (e.g. NodeAggregateNameWasChanged, NodeAggregateTypeWasChanged) | ||
| public ?OriginDimensionSpacePoint $originDimensionSpacePoint, |
There was a problem hiding this comment.
todo the neos ui must learn to handle this case: https://github.com/neos/neos-ui/blob/13520defa0b00eee9cef6073fde11ccbfa3346d4/Classes/ContentRepository/Service/WorkspaceService.php#L83
i assume we need to mark all occupied nodes of the noteaggregate as changes then? And if removalAttachmentPoint is set is probably gurantted that originDimensionSpacePoint is set
There was a problem hiding this comment.
okay it did see neos/neos-ui#3878 but one place was overseen :)
This was referenced Nov 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4191
This introduces a more comprehensive test suite for ChangeNodeType and adds the following features
This also fixes a bug in NodeRemoval where only one child node was removed per removed parent
Additionally, as reported in #4191, the change projection is now able to deal with aggregate scoped changes (NodeAggregateTypeWasChanged, NodeAggregateNameWasChanged)
Upgrade instructions
Requires cr:setup
Review instructions
See change list
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions