Merge pull request #3656 from neos/bugfix/applyMultiplePropertiesFrom…

…Inspector BUGFIX: Apply multiple properties from inspector
neos · Oct 30, 2023 · 15672ed · 15672ed
2 parents 3aa32c1 + 759ebd8
commit 15672ed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php b/Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php
@@ -113,7 +113,7 @@ public function serializePayload(ControllerContext $controllerContext): array
      *
      * @return array<string,?array<string,mixed>>
      */
-    public function serializeNodeRecursively(Node $node, ControllerContext $controllerContext): array
+    private function serializeNodeRecursively(Node $node, ControllerContext $controllerContext): array
     {
         $contentRepository = $this->contentRepositoryRegistry->get($node->subgraphIdentity->contentRepositoryId);
         $nodeAddressFactory = NodeAddressFactory::create($contentRepository);

diff --git a/Classes/Domain/Model/FeedbackCollection.php b/Classes/Domain/Model/FeedbackCollection.php
@@ -48,8 +48,9 @@ public function setControllerContext(ControllerContext $controllerContext)
      */
     public function add(FeedbackInterface $feedback)
     {
-        foreach ($this->feedbacks as $value) {
-            if ($value->isSimilarTo($feedback)) {
+        foreach ($this->feedbacks as $i => $value) {
+            if ($feedback->isSimilarTo($value)) {
+                $this->feedbacks[$i] = $feedback;
                 return;
             }
         }