-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Script: Rename all import style from "./style.css"
to style.module.css
#3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mhsdesign
changed the title
TASK: Rename all
TASK: Script: Rename all Oct 19, 2022
import style from "./style.css"
to style.module.scssimport style from "./style.css"
to style.module.scss
crydotsnake
added
the
Task Stale
Something that would be cool to clean up but is not beeing done
label
Nov 16, 2022
27 tasks
mhsdesign
changed the title
TASK: Script: Rename all
TASK: Script: Rename all Feb 20, 2023
import style from "./style.css"
to style.module.scssimport style from "./style.css"
to style.module.css
mhsdesign
removed
the
Task Stale
Something that would be cool to clean up but is not beeing done
label
Feb 20, 2023
mhsdesign
force-pushed
the
feature/esbuild-scss-modules
branch
from
February 22, 2023 17:27
49b9c80
to
517d236
Compare
mhsdesign
commented
Mar 3, 2023
Comment on lines
-80
to
-81
includeFilter: /\.css$/, | ||
excludeFilter: /@ckeditor\/|@fortawesome\/fontawesome-svg-core\/|styleHostOnly\.css|normalize\.css/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats why we dit it, we dont need that ugly logic anymore as we rely on conventions
markusguenther
approved these changes
Mar 8, 2023
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any build stack gets confused by our "normal"
style.css
files, as they are not namedstyle.module.css
.Sure we can work against that but its clearly better to stick to the conventions
FYI the build works perfectly ;)
No worries it has been done by a script - and can be done again ^^
Show me the wizard who did this: