FEATURE: adjust image editor to allow a custom upload screen component #3302
Conversation
There was a problem hiding this comment.
Hi @andrehoffmann30,
thanks for your PR :)
I was able to get it to work locally. But there's one small adjustment I'd like to suggest (see comment below).
On a larger note:
Adding this feature would change the behavior of the ImageEditor, but would leave the behavior of the AssetEditor intact. Imho the upload mechanism should not differ between the two, so it would be necessary to adjust the AssetEditor as well.
| // set media type constraint to "image/*" if it is not explicitly specified via options.constraints.mediaTypes | ||
| const constraints = {...options.constraints, mediaTypes: (options.constraints && options.constraints.mediaTypes) || ['image/*']}; | ||
| const {component: AssetUploadScreen} = secondaryEditorsRegistry.get('Neos.Neos/Inspector/Secondary/Editors/AssetUploadScreen'); | ||
| this.props.renderSecondaryInspector('IMAGE_UPLOAD_MEDIA', () => <AssetUploadScreen type="images" constraints={constraints} onComplete={this.afterUpload}/>); |
There was a problem hiding this comment.
It would be nice to pass along propertyName, focusedNodePath, siteNodePath and metadata ("Image" or "Asset") as well, so that all the information the uploadAsset endpoint needs is available in the secondary inspector:
https://github.com/neos/neos-ui/blob/8.3/packages/neos-ui-backend-connector/src/Endpoints/index.ts#L224
There was a problem hiding this comment.
Hallo @grebaldi , adjusted the asset editor to be able use the same custom upload dialog as the image editor. I have also adapted the code so that the additional data you mentioned is passed to the dialog. In the implementation of the dialog, you can then use the data accordingly if desired.
andrehoffmann30
restored the
feature/adjust-image-editor-for-upload-screen
branch
andrehoffmann30
force-pushed
the
feature/adjust-image-editor-for-upload-screen
branch
from
ecc6218 to
620d858
Compare
|
Hallo @mhsdesign I changed the merge goal to the 9.0 branch. Can you please adjust the labels accordingly? Thank you. |
There was a problem hiding this comment.
Hi @andrehoffmann30,
thanks a lot for your adjustments! I was able to test everything locally and it works perfectly 👌
markusguenther
force-pushed
the
feature/adjust-image-editor-for-upload-screen
branch
from
620d858 to
232e779
Compare
What I did
I adjusted the image editor to allow a custom upload screen / dialog as an replacement option for the default upload behaviour.
How I did it
I adjusted the
handleChooseFilefunction to look for aMediaUploadScreenin the secondary editors registry. If a component is found , it is used and renderd as a secondary editor for the upload of a file. If no component is found, the previous behaviour is used for handeling the file upload.How to verify it
For testing this behaviour you need to write a plugin and add a component to be used as
MediaUploadScreento the secondary editors registry in your plugin.