-
-
Notifications
You must be signed in to change notification settings - Fork 142
FEATURE: Add inspector default group #3426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.4
Are you sure you want to change the base?
Conversation
Could confirm that this works with properties that have an explicit editor configuration. Not yet sure what would be right but somehow think this should show up in the inspector:
This may be a naive assumption and could lead to all inline fields showing up in the inspector aswell which would be clearly wrong. |
Huh that’s interesting (thx for testing this so well :D) I indeed implemented the check for the editor field, as otherwise all fields are shown in the inspector. i don’t know yet how this correlates to the php nodeType processor (as it is in php and should have been already applied so the editor key should be set nevertheless but I might be wrong or haven’t looked in the right place ) |
I don't think fields without any kind of editor or inspector properties should show up. At least not with this initial change. |
Yes youre right. @mficzel and me just discussed this in the weekly and we agreed to close this one as there is no good way in knowing whether the property is intendet to be shown or not. So until we found better criteria ill close this okay? (The neos part, that we even have a default group, which can be used out of the box will stay - so its at least half of a win ^^) |
I just talked to @Sebobo about this and he is still a fan of this idea and mentioned: one can still use the option What do you think @mficzel ? so we would need to write instead of:
this to hide the properties explicitly:
we could even try to provide a migration for this, or projects would see popping up previously hidden properties ... |
876185a
to
4a2b8fe
Compare
Rebased the PR to 8.4 :) |
Using explicit hidden:true instead of non existing groups sounds like the right way to me. Will need some documentation an I would consider this breaky and prefer a major release for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by testing and discussing. Cannot say much about ts
There are integrators who use a non-existent group to hide stuff, I think even with a condition. So the question would be: Should we have a third state: Match, Null, Non-existent group and hide that one still? |
Neos part: neos/neos-development-collection#4068
Resolves: neos/neos-development-collection#4060
What I did
Use the same code like for the default tabs, but also check if an editor is set as always properties will be shown which dont have an editor configured
How I did it
How to verify it