TASK: Cleanup, remove or declare EEL helpers as internal #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎥 End-to-End Test Recordings These videos demonstrate the end-to-end tests for the changes in this pull request. |
mhsdesign
force-pushed
the
task/cleanupEelHeleprs
branch
from
49f789b to
fa95240
Compare
mhsdesign
changed the title
`getAllowedTargetWorkspaces` has been removed as its unused
mhsdesign
force-pushed
the
task/cleanupEelHeleprs
branch
from
fa95240 to
fa474c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3703
Follow up to #3704
Related #3703
Every eel helper of the Neos Ui is now declared as purely internal.
If for some reason you used any of the latter it must be migrated.
For migration please copy the parts of the respective helper to an own helper or better consider alternative ways.
In case the
Neos.Ui.PositionalArraySorterhelper was frequently used and there is demand for that, we can possibly put it into theArrayhelper as feature.Affected helpers:
The helper
was already made internal and cleaned up via #3703
What I did
How I did it
How to verify it