Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Upgrade to Neos 9 #60

Merged
merged 35 commits into from
Oct 16, 2023
Merged

FEATURE: Upgrade to Neos 9 #60

merged 35 commits into from
Oct 16, 2023

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented May 9, 2023 •
edited
Loading

@dlubitz dlubitz self-assigned this May 9, 2023
@dlubitz dlubitz mentioned this pull request May 9, 2023
Closed
kdambekalns
kdambekalns reviewed May 9, 2023
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just had a quick look, so only some "by reading" comments on things I noticed.

Tests/Behavior/Features/Bootstrap/FeatureContext.php Outdated Show resolved Hide resolved
Tests/Behavior/Features/Bootstrap/FeatureContext.php Outdated Show resolved Hide resolved
Tests/Functional/Service/NodeRedirectServiceTest.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
Classes/Package.php Outdated Show resolved Hide resolved
@dlubitz
Copy link
Contributor Author

dlubitz commented May 9, 2023 •
edited
Loading

Thanks! I just had a quick look, so only some "by reading" comments on things I noticed.

AHH! Sorry, this is not meant to get reviewed yet and is completly WIP. Just wanted to drop the first changes somewhere not on my local. I thought marking as "Draft" would be fine.

@kdambekalns
Copy link
Member

Thanks! I just had a quick look, so only some "by reading" comments on things I noticed.

AHH! Sorry, this is not meant to get reviewed yet and is completly WIP.

I know, it's draft, after all. So, nothing to compain about, totally my decision to have a look already. 😇

@dlubitz dlubitz force-pushed the 90/feature-upgrade-to-neos-9 branch from 1a2db22 to cb6ce03 Compare May 11, 2023 15:15
@dlubitz dlubitz mentioned this pull request Jun 30, 2023
Closed
@dlubitz dlubitz marked this pull request as ready for review September 30, 2023 09:59
ahaeslich
ahaeslich reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@ahaeslich ahaeslich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that an editor

  1. moves a page
  2. publishes the move
  3. deletes the moved page
  4. publishes the deletion

Are we expecting that the database contains two redirect entries with the statusCode 410? One for the original sourceUriPath and one for the last known sourceUriPath?

I tested it and currently all previous source paths are updated to a blank targetUriPath and statusCode 301. The last location of the page gets the statusCode 410 and a blank targetUriPath.

@dlubitz
Copy link
Contributor Author

dlubitz commented Oct 11, 2023

Can you check this PR, if this solves the issue?
neos/redirecthandler-databasestorage#28

@ahaeslich ahaeslich mentioned this pull request Oct 11, 2023
Merged
@ahaeslich
Copy link
Member

Can you check this PR, if this solves the issue? neos/redirecthandler-databasestorage#28

That's it 👍

@ahaeslich ahaeslich self-requested a review October 11, 2023 08:30
mhsdesign
mhsdesign approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care ;) I tested this and it works perfekt.

Also the niche options restrictByNodeType and restrictByOldUriPrefix have been tested successfully.

@dlubitz dlubitz merged commit 6f9fb53 into main Oct 16, 2023
@dlubitz dlubitz deleted the 90/feature-upgrade-to-neos-9 branch October 16, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahaeslich ahaeslich ahaeslich approved these changes

@mhsdesign mhsdesign mhsdesign approved these changes

@kdambekalns kdambekalns Awaiting requested review from kdambekalns

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

@Sebobo Sebobo Awaiting requested review from Sebobo

@markusguenther markusguenther Awaiting requested review from markusguenther

Assignees

@dlubitz dlubitz

Labels
None yet
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust neos/redirecthandler packages for Neos 9
5 participants
@dlubitz @kdambekalns @ahaeslich @bwaidelich @mhsdesign