Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily removed 'dolkha'dialect #209

Merged
merged 4 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nepalingo-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"build": "tsc -b && vite build",
"lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
"format-check": "prettier . --check",
"preview": "vite preview"
"preview": "vite preview",
"format": "prettier . --write"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I like that, thanks!

},
"dependencies": {
"@fortawesome/fontawesome-svg-core": "^6.5.2",
Expand Down
78 changes: 43 additions & 35 deletions nepalingo-web/src/lib/getNewariWord.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,44 +15,52 @@ export async function getNewariWord(word: string): Promise<DictionaryResponse> {
const response: DictionaryResponse = {
language: "newari",
word: word,
//Mapping the meanings from the api to create a custom response based on DictionaryResponse
meanings:
data?.meanings.length == 0
data?.meanings.length === 0
? []
: data?.meanings?.map(
(meaning: {
audio?: { file: string; directory: string };
image?: { file: string; directory: string };
meaning_np?: string;
meaning_nb?: string;
meaning_en?: string;
pos?: string;
dialect?: string;
transliterations?: {
deva: string;
latn: string;
newa: string;
};
}) => ({
audio: meaning?.audio && {
uri: `${import.meta.env.VITE_NEPALBHASA_API_URL}/dict/${meaning.audio.directory}/${meaning.audio.file}`,
},
image: meaning?.image && {
// TODO: Revert this back to 400x400, Currently set to 400x401 to avoid API error
uri: `${import.meta.env.VITE_NEPALBHASA_API_URL}/dict/${meaning.image.directory}/w400h401b1sh1/${meaning.image.file}`,
},
meaningOriginal: meaning?.meaning_nb,
meaningNp: meaning?.meaning_np,
meaningEn: meaning?.meaning_en,
dialect: meaning.dialect,
partsOfSpeech: meaning.pos,
transliterations: {
latn: meaning.transliterations?.latn,
deva: meaning.transliterations?.deva,
original: meaning.transliterations?.newa,
: (data?.meanings
?.map(
(meaning: {
audio?: { file: string; directory: string };
image?: { file: string; directory: string };
meaning_np?: string;
meaning_nb?: string;
meaning_en?: string;
pos?: string;
dialect?: string;
transliterations?: {
deva: string;
latn: string;
newa: string;
};
}) => {
// Skip the 'dolakha' dialect
if (meaning.dialect === "dolakha") {
return null;
}

return {
audio: meaning?.audio && {
uri: `${import.meta.env.VITE_NEPALBHASA_API_URL}/dict/${meaning.audio.directory}/${meaning.audio.file}`,
},
image: meaning?.image && {
// TODO: Revert this back to 400x400, Currently set to 400x401 to avoid API error
uri: `${import.meta.env.VITE_NEPALBHASA_API_URL}/dict/${meaning.image.directory}/w400h401b1sh1/${meaning.image.file}`,
},
meaningOriginal: meaning?.meaning_nb,
meaningNp: meaning?.meaning_np,
meaningEn: meaning?.meaning_en,
dialect: meaning.dialect,
partsOfSpeech: meaning.pos,
transliterations: {
latn: meaning.transliterations?.latn,
deva: meaning.transliterations?.deva,
original: meaning.transliterations?.newa,
},
};
},
}),
),
)
.filter(Boolean) as DictionaryResponse["meanings"]), // Filter out any null entries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment here too!

};
return response;
}
Loading