Add chapters #228
Merged
Add chapters #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Flashcards, only show First Words section for now for all languages. This code needs to be refactored to remove generator. The generator code was not good because it made the useEffect non-idempotent. So getting all words is much cleaner and there is no large downside. It's we'll likely never need to worry about performance for getAllWords because the wordlist is small and split by Chapter anyways.
Deploying nepalingo with
|
| Latest commit: |
1fc3fd7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://65d3b404.nepalingo.pages.dev |
| Branch Preview URL: | https://add-chapters.nepalingo.pages.dev |
|
Merging without review because of time constraints, if anyone has comments, happy to follow up with another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds chapters and fixes header
For the header, made it so the logo shrinks proportionally instead of being squished, and on small devices the links move below the header
