-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Build.yaml and Lint.yaml files for pullrequest #55
Conversation
Deploying nepalingo with Cloudflare Pages
|
Co-authored-by: binamkayastha <binamkayastha@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Looks like your builds are failing though because you don't have pnpm installed.
You can use the pnpm official github action to do that: https://stackoverflow.com/questions/76664013/how-to-use-pnpm-instead-of-npm-in-github-actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Created a build and lint file for CI and want feedback.
Also want to discuss for the discussion to setup github branch protection rules on these checks