Action fix #133
Merged
Action fix #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@QuanMPhm do you know the next steps for resolving the microshift test failure? |
|
Apparently it takes a lot longer to pull the account manager image from ghcr. I'll need to increase the timeout to 16 minutes |
Isn't it because you need to update the pin, rather than the timeout? https://github.com/nerc-project/coldfront-plugin-cloud/blob/ea54a6af62da5301619ec6e4108b314d1f32f8e1/.github/workflows/test-py39-functional-microshift.yaml#L12C22-L12C62 |
|
@knikolla You are right. The pin was the problem. I've updated it |
jtriley
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #91, the Github action file is changed to use the public image on ghcr. The unit tests should pass if the related PR in
acct-manageris accepted first.closes #91