Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented 'nerc-rates' for storage invoicing #169

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

QuanMPhm
Copy link
Contributor

Closes #167 , I have modified calculate_storage_gb_hours to use the storage rates stored in the nerc-rates repo.

@joachimweyl
Copy link

@naved001 & @knikolla when you get a chance please check out this 16 line change PR.

Copy link
Collaborator

@knikolla knikolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove the original arguments, let nerc-rates provide the defaults only if no argument was provided from the command line.

@QuanMPhm
Copy link
Contributor Author

@knikolla Is this PR still being considered?

@knikolla knikolla merged commit 591aa23 into nerc-project:main Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use nerc-rates for storage invoicing
3 participants