Fix default output validator #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaojunda
reviewed
Nov 1, 2024
| @@ -128,7 +128,7 @@ def generate_tx(target_address, capacity, data = "0x", key: nil, fee: 0, use_dep | |||
| # @param data [String] "0x..." | |||
| # @param key [CKB::Key | String] Key or private key hex string | |||
| # @param fee [Integer] transaction fee, in shannon | |||
| def send_capacity(target_address, capacity, data = "0x", key: nil, fee: 0, outputs_validator: "default", from_block_number: 0) | |||
| def send_capacity(target_address, capacity, data = "0x", key: nil, fee: 0, outputs_validator: "passthrough", from_block_number: 0) | |||
There was a problem hiding this comment.
I believe it is safer to set the default value of outputs_validator to 'default'
There was a problem hiding this comment.
CKB provides two built-in validators, well_known_scripts_only and passthrough. When no validator is specified, well_known_scripts_only is used.
you means set well_known_scripts_only to be default?
now outputs_validator: "default" will report an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
OutputsValidatorTransaction output validators that prevent common mistakes.
It's an enum value from one of: