Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add useful information to certain Error variants #393

Merged
merged 2 commits into from
Dec 18, 2023
Merged

chore: Add useful information to certain Error variants #393

merged 2 commits into from
Dec 18, 2023

Commits on Dec 15, 2023

  1. chore: Add useful information to certain Error variants 

    This commit revisits Error type with additional information that would
help debugging, such as addresses to access in memory errors, and
segment vaddr in Elf errors.

To preserve the required information, one additional assembly line is
required in each WRITE operation of x64 implementation. The arm64 code
does not suffer from any additional assembly code, in fact, we also
took the liberty to reduce a few unnecessary arm64 assembly lines.
    @xxuejie
    xxuejie committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    768347f View commit details
    Browse the repository at this point in the history

  2. fix: Addition overflows

    @xxuejie
    xxuejie committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d09434a View commit details
    Browse the repository at this point in the history