Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBF will also replace tx not in Pending #4231

Merged
merged 2 commits into from
Nov 20, 2023
Merged

RBF will also replace tx not in Pending #4231

merged 2 commits into from
Nov 20, 2023

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

To keep it consistent, now RBF will also can replace tx not in Pending.

Problem Summary:

What is changed and how it works?

Drop Rule #6 and fix tests.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner November 15, 2023 03:37
@chenyukang chenyukang requested review from doitian and removed request for a team November 15, 2023 03:37
@doitian
Copy link
Member

doitian commented Nov 15, 2023

Please create another backport PR onto rc/v0.102.x

@chenyukang
Copy link
Collaborator Author

Please create another backport PR onto rc/v0.102.x

created a new PR to rc/v0.112.x.

@quake quake added this pull request to the merge queue Nov 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 16, 2023
@chenyukang chenyukang added this pull request to the merge queue Nov 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 16, 2023
@chenyukang chenyukang added this pull request to the merge queue Nov 20, 2023
Merged via the queue into nervosnetwork:develop with commit af4e3c1 Nov 20, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyukang @doitian @quake @eval-exec