feat: introduce init tip setting for indexer to skip previous block synchronization
#4244
Conversation
- get_indexer_tip - rollback
EthanYuan
requested review from
zhangsoledad and
quake
and removed request for
a team
| # # The initial tip number and hash can be set as the starting height for building indexes in indexer-r. Effective only during the initial index creation. | ||
| # init_tip_number = 10000 | ||
| # # The initial tip hash must match the tip number; otherwise, it will result in a rollback to empty. | ||
| # init_tip_hash = "0x8fbd0ec887159d2814cee475911600e3589849670f5ee1ed9798b38fdeef4e44" |
There was a problem hiding this comment.
suggest to use one block hash parameter only, indexer may use get_header rpc to fetch the block number, and start the indexing service only when corresponding header was found.
There was a problem hiding this comment.
Entering a number manually considering a situation where the block height of the node itself may not have been reached and get_header may fail.
There was a problem hiding this comment.
please refer to my previous comment:
start the indexing service only when corresponding header was found.
There was a problem hiding this comment.
Another issue is that if the hash is wrong, then there is no chance of rollback.
There was a problem hiding this comment.
indexer service won't starting if the hash is wrong.
What problem does this PR solve?
Problem Summary:
CKB-indexer supports building indexes only for interested blocks. This can be done by setting
block_filterbefore this PR. But the filter can only traverse the block from 0 and for the uninterested block also need to save itsHeader(BlockNumber, &'a Byte32, bool).What is changed and how it works?
This pr introduces the
init tipsetting, which can be set directly when the indexer initializes the database for the first time, which brings two benefits:What's Changed:
apply_init_tipfunction, which is called inIndexerService::newRelated changes
This feature will also be used for index-r:
Check List
Tests
Header(BlockNumber, &'a Byte32, bool)Side effects
Release note