Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Split machine running logic from run into detailed_run method #4263

Merged

Conversation

xxuejie
Copy link
Collaborator

@xxuejie xxuejie commented Dec 15, 2023

With a public detailed_run method, one can get the resulting machine from running a single script in a CKB transaction. With a full machine instance, further inspections upon errors can be simpler.

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

None: Exclude this PR from the release note.
Title Only: Include only the PR title in the release note.
Note: Add a note under the PR title in the release note.

@xxuejie xxuejie requested a review from a team as a code owner December 15, 2023 03:34
@xxuejie xxuejie requested review from zhangsoledad and removed request for a team December 15, 2023 03:34
With a public `detailed_run` method, one can get the resulting machine
from running a single script in a CKB transaction. With a full machine
instance, further inspections upon errors can be simpler.
@xxuejie xxuejie force-pushed the split-detailed-run-from-run branch from 663e3e2 to 3e8e57d Compare December 15, 2023 03:44
@zhangsoledad zhangsoledad added this pull request to the merge queue Dec 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Dec 18, 2023
Merged via the queue into nervosnetwork:develop with commit 72f3f08 Dec 18, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants