Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAK CHANGE for RPC get_pool_tx_detail_info: Change score_sortkey's type from String to struct AncestorsScoreSortKey #4273

Merged
merged 8 commits into from
Dec 25, 2023
Merged

BREAK CHANGE for RPC get_pool_tx_detail_info: Change score_sortkey's type from String to struct AncestorsScoreSortKey #4273

merged 8 commits into from
Dec 25, 2023

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

This PR updated the type of struct PoolTxDetailInfo::score_sortkey from String to struct AncestorsScoreSortKey. This change makes it easier to parse and work with.

What's Changed:

Related changes

  • Change score_sortkey's type from String to struct AncestorsScoreSortKey

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec added the b:rpc Break RPC interface label Dec 25, 2023
@eval-exec eval-exec requested a review from a team as a code owner December 25, 2023 06:49
@chenyukang chenyukang added this pull request to the merge queue Dec 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 25, 2023
@eval-exec eval-exec added this pull request to the merge queue Dec 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 25, 2023
@eval-exec eval-exec added this pull request to the merge queue Dec 25, 2023
Merged via the queue into nervosnetwork:develop with commit 5c3e0bb Dec 25, 2023
31 checks passed
@eval-exec eval-exec mentioned this pull request Jan 2, 2024
Merged
@eval-exec eval-exec changed the title Change score_sortkey's type from String to struct AncestorsScoreSortKey BREAK CHANGE for RPC get_pool_tx_detail_info: Change score_sortkey's type from String to struct AncestorsScoreSortKey Jan 2, 2024
doitian added a commit that referenced this pull request Jan 2, 2024
@doitian
Merge pull request #4288 from eval-exec/exec/get_pool_tx_detail_info_rc
b409568 
Backport #4273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@chenyukang chenyukang Awaiting requested review from chenyukang

Assignees
No one assigned
Labels
b:rpc Break RPC interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @quake