Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ActiveChain's state: SyncState field, reuse ActiveChain#shared#state instead #4302

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Remove ActiveChain's state: SyncState field, reuse ActiveChain#shared#state instead #4302

merged 2 commits into from
Jan 16, 2024

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

ActiveChain#shared#state and ActiveChain#state are duplicated. Should reuse ActiveChain#shared#state only.

Related changes

  • Remove ActiveChain's state field

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from quake January 16, 2024 04:37
@eval-exec eval-exec marked this pull request as ready for review January 16, 2024 04:37
@eval-exec eval-exec requested a review from a team as a code owner January 16, 2024 04:37
@quake quake added this pull request to the merge queue Jan 16, 2024
Merged via the queue into nervosnetwork:develop with commit 9855826 Jan 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@quake quake quake approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @quake @driftluo