backport: Fix RPC cors issue of preflight request #4308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Because current default cors setting, if we send request from browser console, we met this issue:
Access to fetch at 'http://127.0.0.1:8114/' from origin 'null' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
Problem Summary:
What is changed and how it works?
CorsLayer::permissive()
for a permissive setting forcors
.keep-alive
by the way, our current setting is setkeep-alive
whenwebsockets
is enabled, we should set it by default.What's Changed:
Related changes
owner/repo
:Check List
Tests
Side effects
Release note