Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: fix make clippy failed on develop #4828

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

After v0.200.0 released, make clippy failed on develop since we merged master into develop: 33446e8

    Checking petgraph v0.6.5
error: empty line after doc comment
 --> util/constant/src/default_assume_valid_target.rs:1:1
  |
1 | / /// Get default assume valid targets
2 | |
  | |_^
3 |   /// mainnet
4 |   pub mod mainnet {
  |   --------------- the comment documents this module
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
  = note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]`
  = help: if the empty line is unintentional remove it
help: if the comment should document the parent module use an inner doc comment
  |
1 | //! Get default assume valid targets
  |   ~
help: if the documentation should include the empty line include it in the comment
  |
2 | ///
  |

error: empty line after doc comment
 --> util/constant/src/latest_assume_valid_target.rs:4:1
  |
4 | / ///
5 | |
  | |_^
6 |   /// sync config related to mainnet
7 |   pub mod mainnet {
  |   --------------- the comment documents this module
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
  = help: if the empty line is unintentional remove it
help: if the comment should document the parent module use an inner doc comment
  |
1 ~ //! The mod mainnet and mod testnet's codes are generated
2 ~ //! by script: ./devtools/release/update_default_valid_target.sh
3 ~ //! Please don't modify them manually.
4 ~ //!
  |
help: if the documentation should include the empty line include it in the comment
  |
5 | ///
  |

    Checking thread-id v4.2.2
error: could not compile `ckb-constant` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
make: *** [Makefile:192: clippy] Error 101

Related changes

  • Fix clippy warning

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner March 5, 2025 14:22
@eval-exec eval-exec requested review from doitian and removed request for a team March 5, 2025 14:22
@eval-exec eval-exec added this pull request to the merge queue Mar 6, 2025
Merged via the queue into nervosnetwork:develop with commit 2d30744 Mar 6, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants