feat: update notarize to 2.0.0

nervosnetwork · Jun 29, 2023 · e7f9416 · e7f9416
1 parent 5203ea3
commit e7f9416
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/.github/workflows/package_for_test.yml b/.github/workflows/package_for_test.yml
@@ -90,7 +90,7 @@ jobs:
       - name: Install Lerna
         run: yarn global add lerna
 
-      - name: Boostrap
+      - name: Bootstrap
         run: |
           yarn
         env:

diff --git a/packages/neuron-wallet/package.json b/packages/neuron-wallet/package.json
@@ -68,7 +68,7 @@
     "uuid": "8.3.2"
   },
   "devDependencies": {
-    "@electron/notarize": "1.2.4",
+    "@electron/notarize": "2.0.0",
     "@nervosnetwork/ckb-types": "0.109.0",
     "@types/archiver": "3.1.1",
     "@types/async": "3.2.20",

diff --git a/packages/neuron-wallet/scripts/notarize.js b/packages/neuron-wallet/scripts/notarize.js
@@ -13,9 +13,10 @@ exports.default = async function notarizing(context) {
 
   const appleId = process.env.APPLE_ID;
   const appleIdPassword = process.env.APPLE_ID_PASSWORD;
+  const teamId = process.env.TEAM_ID;
 
-  if (!appleId || !appleIdPassword) {
-    console.warn(`${appleId ? "Apple id password" : "Apple id"} is not found`)
+  if (!appleId || !appleIdPassword || !teamId) {
+    console.warn(`${appleId ? (appleIdPassword ? "Team id" : "Apple id password") : "Apple id"} is not found`)
     process.exit(1)
   }
 
@@ -27,8 +28,9 @@ exports.default = async function notarizing(context) {
     await notarize({
       appBundleId: 'com.nervos.neuron',
       appPath: `${appOutDir}/${appName}.app`,
-      appleId: appleId,
-      appleIdPassword: appleIdPassword,
+      appleId,
+      appleIdPassword,
+      teamId,
     })
     console.info("Notarization finished")
   } catch (err) {

diff --git a/yarn.lock b/yarn.lock
@@ -1650,10 +1650,10 @@
   optionalDependencies:
     global-agent "^3.0.0"
 
-"@electron/notarize@1.2.4":
-  version "1.2.4"
-  resolved "https://registry.yarnpkg.com/@electron/notarize/-/notarize-1.2.4.tgz#a7d38773f4cad40df111a5edc64037e5d768ea1e"
-  integrity sha512-W5GQhJEosFNafewnS28d3bpQ37/s91CDWqxVchHfmv2dQSTWpOzNlUVQwYzC1ay5bChRV/A9BTL68yj0Pa+TSg==
+"@electron/notarize@2.0.0":
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/@electron/notarize/-/notarize-2.0.0.tgz#4df39e817264746aa9bd779e0091b6c441715b72"
+  integrity sha512-dqDpd2YCgl6PHJgXEuKGYH3+L4GIGV7ZbKYJjJv66ed+hVPxZA+GAL5JH8/hCnoyQa8WzJTzqd+qhiL5Oxr+SA==
   dependencies:
     debug "^4.1.1"
     fs-extra "^9.0.1"