fix: comment

nervosnetwork · Jan 4, 2025 · ea6b9a7 · ea6b9a7 · github-actions · Jan 4, 2025
1 parent 6ccc0f0
commit ea6b9a7
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 19 deletions.
diff --git a/packages/neuron-ui/src/components/Receive/receive.module.scss b/packages/neuron-ui/src/components/Receive/receive.module.scss
@@ -136,7 +136,6 @@
     border: none;
     background: none;
     font-size: 12px;
-    font-family: PingFang SC;
     font-style: normal;
     font-weight: 500;
     color: var(--primary-color);

diff --git a/packages/neuron-ui/src/components/ViewPrivateKey/index.tsx b/packages/neuron-ui/src/components/ViewPrivateKey/index.tsx
@@ -35,31 +35,29 @@ const ViewPrivateKey = ({ onClose, address }: { onClose?: () => void; address?:
   )
 
   const onSubmit = useCallback(
-    async (e?: React.FormEvent) => {
+    (e?: React.FormEvent) => {
       if (e) {
         e.preventDefault()
       }
       if (!password) {
         return
       }
       setIsLoading(true)
-      try {
-        const res = await getPrivateKeyByAddress({
-          walletID,
-          address,
-          password,
+      getPrivateKeyByAddress({
+        walletID,
+        address,
+        password,
+      })
+        .then(res => {
+          if (!isSuccessResponse(res)) {
+            setError(errorFormatter(res.message, t))
+            return
+          }
+          setPrivateKey(res.result)
+        })
+        .finally(() => {
+          setIsLoading(false)
         })
-
-        setIsLoading(false)
-
-        if (!isSuccessResponse(res)) {
-          setError(errorFormatter(res.message, t))
-          return
-        }
-        setPrivateKey(res.result)
-      } catch (err) {
-        setIsLoading(false)
-      }
     },
     [walletID, password, setError, t]
   )

diff --git a/packages/neuron-wallet/tests/services/address.test.ts b/packages/neuron-wallet/tests/services/address.test.ts
@@ -748,7 +748,9 @@ describe('integration tests for AddressService', () => {
         const addresses = await wallet.checkAndGenerateAddresses(false, 5, 5)
 
         if (addresses) {
-          const obj = addresses[Math.floor(Math.random() * addresses.length)]
+          const crypto = require('crypto')
+          const randomIndex = crypto.randomInt(addresses.length)
+          const obj = addresses[randomIndex]
           address = obj.address
         }