Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Multisig Address with new ui #2666

Merged
merged 13 commits into from
Jun 28, 2023
Merged

feat: Multisig Address with new ui #2666

merged 13 commits into from
Jun 28, 2023

Conversation

devchenyan
Copy link
Collaborator

@devchenyan devchenyan commented May 13, 2023 •
edited
Loading

  • Light Theme
Screen-2023-05-13-.62848.mp4
  • Dark Theme
dark.mp4

@devchenyan devchenyan marked this pull request as ready for review May 13, 2023 10:29
@devchenyan devchenyan mentioned this pull request May 13, 2023
Closed
@devchenyan devchenyan requested review from yanguoyu, WhiteMinds, Keith-CY, alexsupa597 and FrederLu and removed request for yanguoyu and WhiteMinds May 15, 2023 02:12
@Keith-CY Keith-CY requested a review from WhiteMinds May 21, 2023 16:04
@yanguoyu
Copy link
Collaborator

If we do not show multisig and sign-verify in a new window, how about only using a dialog component in , but not using a router to show these dialogs?
What is the difference between using router and use dialog component?

@github-actions
Copy link
Contributor

Packaging for test is done in 5297387383 for commit 33f1723 .

@silySuper silySuper requested a review from yanguoyu June 20, 2023 02:08
@Keith-CY Keith-CY deleted the branch nervosnetwork:develop June 20, 2023 08:39
@Keith-CY Keith-CY closed this Jun 20, 2023
@devchenyan devchenyan reopened this Jun 20, 2023
@devchenyan devchenyan changed the base branch from new-ui-design to develop June 20, 2023 13:58
@github-actions
Copy link
Contributor

Packaging for test is done in 5328873087 for commit 9d49be4 .

@silySuper silySuper self-requested a review June 25, 2023 01:27
@silySuper
Copy link
Collaborator

@devchenyan please handle this review ，thank you～

@github-actions
Copy link
Contributor

Packaging for test is done in 5369957051 for commit 2f23007 .

@devchenyan devchenyan requested a review from yanguoyu June 26, 2023 01:18
@github-actions
Copy link
Contributor

Packaging for test is done in 5372803102 for commit 039f68b .

@github-actions
Copy link
Contributor

Packaging for test is done in 5372978150 for commit 3e1f02f .

alexsupa597
alexsupa597 reviewed Jun 27, 2023
View reviewed changes
packages/neuron-ui/src/components/ApproveMultisigTxDialog/index.tsx Outdated Show resolved Hide resolved
packages/neuron-ui/src/components/MultisigAddress/hooks.ts Outdated Show resolved Hide resolved
packages/neuron-ui/src/components/MultisigAddress/index.tsx Outdated Show resolved Hide resolved
packages/neuron-ui/src/components/MultisigAddress/multisigAddress.module.scss Outdated Show resolved Hide resolved
packages/neuron-ui/src/components/MultisigAddress/multisigAddress.module.scss Outdated Show resolved Hide resolved
packages/neuron-ui/src/components/MultisigAddressInfo/index.tsx Show resolved Hide resolved
packages/neuron-ui/src/components/MultisigAddressInfo/index.tsx Show resolved Hide resolved
packages/neuron-ui/src/components/SendFieldset/index.tsx Show resolved Hide resolved
packages/neuron-ui/src/components/SendFieldset/index.tsx Outdated Show resolved Hide resolved
packages/neuron-ui/src/widgets/Dialog/dialog.module.scss Show resolved Hide resolved
@github-actions
Copy link
Contributor

Packaging for test is done in 5390555720 for commit cda1c2e .

@github-actions
Copy link
Contributor

Packaging for test is done in 5399878886 for commit 79f9743 .

@devchenyan devchenyan added this pull request to the merge queue Jun 28, 2023
Merged via the queue into nervosnetwork:develop with commit f2f5708 Jun 28, 2023
11 checks passed
@devchenyan devchenyan deleted the feat-multisig-address branch June 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhiteMinds WhiteMinds WhiteMinds approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@alexsupa597 alexsupa597 alexsupa597 approved these changes

@Keith-CY Keith-CY Awaiting requested review from Keith-CY

@FrederLu FrederLu Awaiting requested review from FrederLu

@silySuper silySuper Awaiting requested review from silySuper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devchenyan @yanguoyu @silySuper @WhiteMinds @alexsupa597 @Keith-CY