Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new customized assets #2667

Merged

Conversation

alexsupa597
Copy link
Contributor

@alexsupa597 alexsupa597 commented May 14, 2023

What problem does this PR solve?

As title.

2023-05-15.00.31.31.mov

UI: https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=319-4539&t=4MpXe3H3ETJkrm3H-0

Ref: Magickbase/neuron-public-issues#117

Check List

Test

e2e Test

@alexsupa597 alexsupa597 marked this pull request as draft May 14, 2023 01:54
@alexsupa597 alexsupa597 marked this pull request as ready for review May 14, 2023 16:27
@alexsupa597 alexsupa597 force-pushed the feat/new-customized-assets branch 2 times, most recently from 5ebe652 to 34d21f3 Compare May 15, 2023 08:52
@yanguoyu
Copy link
Collaborator

You'd better showcase all the features in the movie.
image

@Keith-CY Keith-CY deleted the branch nervosnetwork:develop June 20, 2023 08:39
@Keith-CY Keith-CY closed this Jun 20, 2023
@alexsupa597 alexsupa597 reopened this Jun 20, 2023
@alexsupa597 alexsupa597 changed the base branch from new-ui-design to develop June 20, 2023 14:02
@littleLip520
Copy link

@JeffreyMa597 please help to push this review

@alexsupa597 alexsupa597 force-pushed the feat/new-customized-assets branch 2 times, most recently from e085ae5 to 1a816fe Compare June 28, 2023 09:56
@github-actions
Copy link
Contributor

Packaging for test is done in 5399747847 for commit 1a816fe .

@github-actions
Copy link
Contributor

Packaging for test is done in 5410368526 for commit 84cd591 .

.vscode/settings.json Outdated Show resolved Hide resolved
@devchenyan devchenyan added this pull request to the merge queue Jul 27, 2023
Merged via the queue into nervosnetwork:develop with commit 0d23958 Jul 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants