-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: recent activities style questions #2735
Merged
alexsupa597
merged 3 commits into
nervosnetwork:develop
from
alexsupa597:fix/recent-activities-style-questions
Jul 5, 2023
Merged
fix: recent activities style questions #2735
alexsupa597
merged 3 commits into
nervosnetwork:develop
from
alexsupa597:fix/recent-activities-style-questions
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
alexsupa597
requested review from
Keith-CY,
WhiteMinds,
devchenyan,
yanguoyu and
FrederLu
June 20, 2023 14:06
Packaging for test is done in 5323575293 for commit 8b6bf06 . |
yanguoyu
reviewed
Jun 21, 2023
WhiteMinds
suggested changes
Jun 21, 2023
alexsupa597
force-pushed
the
fix/recent-activities-style-questions
branch
from
July 1, 2023 16:57
8b6bf06
to
247e094
Compare
yanguoyu
reviewed
Jul 2, 2023
alexsupa597
force-pushed
the
fix/recent-activities-style-questions
branch
from
July 2, 2023 08:00
247e094
to
b6296a5
Compare
alexsupa597
force-pushed
the
fix/recent-activities-style-questions
branch
2 times, most recently
from
July 2, 2023 10:48
61afac6
to
f58cfd3
Compare
yanguoyu
approved these changes
Jul 3, 2023
devchenyan
reviewed
Jul 3, 2023
packages/neuron-ui/src/components/FormattedTokenAmount/formattedTokenAmount.module.scss
Outdated
Show resolved
Hide resolved
packages/neuron-ui/src/components/FormattedTokenAmount/index.tsx
Outdated
Show resolved
Hide resolved
alexsupa597
force-pushed
the
fix/recent-activities-style-questions
branch
from
July 3, 2023 08:20
69da98e
to
66a8d46
Compare
WhiteMinds
approved these changes
Jul 3, 2023
Already 3 approvals from developers, please have a review @FrederLu @littleLip520 @silySuper |
Contributor
Author
/package retry |
FrederLu
approved these changes
Jul 4, 2023
devchenyan
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As title.
Ref: Magickbase/neuron-public-issues#168
Check List
Test
e2e Test