Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libretro: Update the list of static language libraries #2592

Merged
merged 1 commit into from
May 21, 2024

Conversation

RobLoach
Copy link
Contributor

I'm unsure if this is the correct approach, but I've updated the cmake definition for libretro to construct a list of language libraries to static link against. Found that on some platforms, since JS was disabled, it wasn't able to find libquickjs.a, so hopefully this fixes it.

@nesbox nesbox merged commit 0602a61 into nesbox:main May 21, 2024
12 checks passed
@nesbox
Copy link
Owner

nesbox commented May 21, 2024

I think your fix works, but it's a bit redundant. I'm not sure if you need to link to each language library individually, because libtic80core.a already contains them in a static build if you define the -DBUILD_WITH_ALL=ON -DBUILD_STATIC=ON option to build all supported languages.

@nesbox
Copy link
Owner

nesbox commented May 21, 2024

ahh, thank you for the support 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants