Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: FFT support #2607

Merged
merged 7 commits into from
May 29, 2024
Merged

Feature: FFT support #2607

merged 7 commits into from
May 29, 2024

Conversation

aliceisjustplaying
Copy link
Collaborator

@aliceisjustplaying aliceisjustplaying commented May 26, 2024

Oh my god we finally got here.

A few comments:

  • The feature is hidden behind the --fft flag. If it's not enabled or we're on unsupported platforms (3DS, baremetal PI, Android) the functions fft() and ffts() simply return 0 and nothing gets even initialized.
  • Took the liberty to add the authors of the past Byte Battle / FFT patches to the contributors as well as the prior work in @TheNuSan's Bonzomatic fork. Let me know if you'd like any changes regarding that
  • Had to squash most of the FFT feature into one commit because rebasing became nigh-impossible after some recent changes
  • Passing around fftdata.h is kind of gnarly but it's the least bad solution I've found. If you have ideas for improvements they're extremely welcome
  • This feature will definitely keep evolving, but this is a good moment to merge it to upstream and iterate from there

@aliceisjustplaying aliceisjustplaying requested a review from nesbox May 26, 2024 19:51
@aliceisjustplaying aliceisjustplaying self-assigned this May 26, 2024
Byte Battle / FFT patches + the FFT features from Bonzomatic to contributors in README
@nesbox nesbox merged commit 43a0317 into nesbox:main May 29, 2024
12 checks passed
@nesbox
Copy link
Owner

nesbox commented May 29, 2024

@aliceisjustplaying Awesome, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants