Proposal: remove support for sokol
#2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I had plans to use Sokol library as the default renderer for win/linux/mac/wasm/android and I started implementing it on this branch https://github.com/nesbox/TIC-80/tree/sokol |
|
We can remove Sokol support for now, but in the future, I'm going to bring it back by default |
nesbox
approved these changes
Aug 26, 2024
|
Yeah I didn't see that one. I stumbled into this bc based on my research it doesn't handle keyboard layout changes which I kind of needed for the AZERTY fix. |
|
There are ways to do keyboard shortcuts that are keyboard-layout independent except here we do need that, for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell this is not used anywhere anymore. It's not part of the latest release, doesn't get auto-built in the CI, and there aren't even instructions to build in the README either.
There may be use cases I'm not aware of, though.
If it's truly not in use, my proposal would be to simply remove it.